fix: L1 cosmenticFlags rename, H10 panic fix, L2 .hawk cwd-leak - #51
Merged
Conversation
Patel230
changed the title
Patel230
marked this pull request as ready for review
June 17, 2026 14:51
Patel230
added a commit
that referenced
this pull request
Jun 18, 2026
* fix(permissions): rename cosmenticFlags to cosmeticFlags (L1) * fix(engine): use comma-ok form in formatNode to avoid panic on non-Expr nodes (H10) * fix(state): resolve .hawk/ paths to home dir to stop cwd-leak (L2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three no-decision deferred items from the post-merge cleanup plan:
cosmenticFlags→cosmeticFlagsininternal/permissions/canonicalize.gonode.(ast.Expr)with comma-ok form ininternal/engine/semantic_diff.go:formatNodeto prevent panic on non-Expr nodes (e.g.*ast.Comment)os.UserHomeDir() + "/.hawk/"for the four state-store default paths so state stops leaking into<cwd>/cmd/.hawk/when hawk is run from its own source treeTest plan
rg cosmenticFlags hawk/returns zerogo test ./internal/engine/...includes newformatNodetest that calls it with&ast.Comment{...}and asserts"unknown"os.UserHomeDir()gofmt/gofumptcleango vet ./...cleango test ./internal/...green